OCPBUGS-25483: Adds CloudConfigTransformer for Azure #316
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
theobarberbany
force-pushed
the
tb/OCPBUGS-25483
branch
from
d3e90ce to
b515766
Compare
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information.
theobarberbany
force-pushed
the
tb/OCPBUGS-25483
branch
from
b515766 to
f940a7c
Compare
|
/test fmt |
This change adds the functionality from the cluster-config-operator
azure CloudConfigTransformer.
The functionality we bring over is:
1. Ensure that the Cloud is set in the cloud.conf
i. If it is set, verify that it is valid and does not conflict with the
infrastructure config. If it conflicts, we want to error
ii. If it is not set, default to public cloud (configv1.AzurePublicCloud)
2. Verify the cloud name set in the infra config is valid, if it is not
bail with an informative error
See openshift/cluster-config-operator#133 for
the PR that initially added this functionality.
Adds tests for the vmType transformations.
This change stops the tests from segfaulting, as the new config transformer for Azure expects a PlatformStatus to be set.
|
/test unit |
theobarberbany
force-pushed
the
tb/OCPBUGS-25483
branch
2 times, most recently
from
1271996 to
6130bfb
Compare
|
/test unit |
|
/retest required |
|
@theobarberbany: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/test e2e-azure-ovn |
This changes the tests to work with valid JSON as it is now a requirement of the azure transformer.
theobarberbany
force-pushed
the
tb/OCPBUGS-25483
branch
from
6130bfb to
0e4bcb3
Compare
|
/retest required |
|
@theobarberbany: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/test e2e-azure-ovn |
This adds the tests from the CCO: https://github.com/openshift/cluster-config-operator/blob/master/pkg/operator/kube_cloud_config/azure_test.go which is where we have pulled the new functionality from.
`map[T]struct{}` is more efficient than `map[T]bool`
|
/retest |
|
/test unit |
|
/test e2e-azure-ovn-upgrade |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
theobarberbany
changed the title
openshift-ci-robot
added
jira/severity-important
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-25483, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-25483, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-25483, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-25483, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/retest-required |
|
@theobarberbany: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@theobarberbany: Jira Issue OCPBUGS-25483: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-25483 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202401042211.p0.gca380e9.assembly.stream for distgit ose-cluster-cloud-controller-manager-operator. |
|
/cherry-pick release-4.15 |
|
@sdodson: new pull request created: #317 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset.
It also adds the functionality from the cluster-config-operator azure CloudConfigTransformer, as we can no longer rely on it by introducing this transformer.
See #291, OCPBUGS-25483 and OCPBUGS-20213 for more information.